Re: [RFC PATCH v2 2/2] headers: include dependent headers
flat view
From: René Scharfe <hidden>
Date: 2016-06-15 23:02:27
Subsystem:
the rest · Maintainer:
Linus Torvalds
Am 07.09.2014 um 02:30 schrieb David Aguilar:
Add dependent headers so that including a header does not require including additional headers. This makes it so that "gcc -c $header" succeeds for each header. Signed-off-by: David Aguilar <redacted> --- Addresses René's note to not include strbuf.h when cache.h is already included.
Perhaps squash this in in order to catch two more cases and also avoid including git-compat-util.h if we already have cache.h:
diff --git a/builtin.h b/builtin.h
index df40fce..0419af3 100644
--- a/builtin.h
+++ b/builtin.h@@ -1,7 +1,6 @@ #ifndef BUILTIN_H #define BUILTIN_H -#include "git-compat-util.h" #include "cache.h" #include "commit.h"
diff --git a/commit.h b/commit.h
index 1fe0731..dddc876 100644
--- a/commit.h
+++ b/commit.h@@ -3,7 +3,6 @@ #include "object.h" #include "tree.h" -#include "strbuf.h" #include "decorate.h" #include "gpg-interface.h" #include "string-list.h"
diff --git a/dir.h b/dir.h
index 727160e..6b00001 100644
--- a/dir.h
+++ b/dir.h@@ -3,7 +3,6 @@ /* See Documentation/technical/api-directory-listing.txt */ -#include "strbuf.h" #include "pathspec.h" #include "cache.h"
diff --git a/khash.h b/khash.h
index 89f9579..fc8b1bf 100644
--- a/khash.h
+++ b/khash.h@@ -26,7 +26,6 @@ #ifndef __AC_KHASH_H #define __AC_KHASH_H -#include "git-compat-util.h" #include "cache.h" #define AC_VERSION_KHASH_H "0.2.8"