Thread (14 messages) 14 messages, 3 authors, 2016-06-15

Re: [PATCH 3/5] fast-import: clean up pack_data pointer in end_packfile

flat view

From: Jeff King <hidden>
Date: 2016-06-15 23:02:20

On Mon, Aug 25, 2014 at 10:16:52AM -0700, Ronnie Sahlberg wrote:
Print an error before returning when pack_data is NULL ?
I don't think so. We call end_packfile in some code paths (like the die
handler) as "close if it's open". So I think it makes sense for it to be
a noop if nothing is open.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help