Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v3 2/3] Introduce GIT_MMAP_LIMIT to allow testing expected mmap size

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:02:19

Steffen Prohaska [off-list ref] writes:
quoted
quoted
+	if (limit == -1) {
+		const char *env = getenv("GIT_MMAP_LIMIT");
+		limit = env ? atoi(env) * 1024 : 0;
... this should then be changed to atol(env), and ... 
In the real codepath (not debugging aid like this) we try to avoid
atoi/atol so that we can catch errors like feeding "123Q" and
parsing it as 123.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help