Re: [PATCH] Check order when reading index
From: Duy Nguyen <hidden>
Date: 2016-06-15 23:02:19
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] Check order when reading index · Junio C Hamano <hidden>
On Thu, Aug 21, 2014 at 8:43 PM, Jaime Soriano Pastor [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -1499,6 +1514,9 @@ int read_index_from(struct index_state *istate, const char *path) ce = create_from_disk(disk_ce, &consumed, previous_name); set_index_entry(istate, i, ce); + if (i > 0) + check_next_ce(istate->cache[i-1], ce); + src_offset += consumed; } strbuf_release(&previous_name_buf);
It may be nice to save the "good index" stamp as an index extension so we don't have to check this over and over. I'm thinking about big indexes where compare cost might matter (I'm not so sure yet, will do some testing when I have time). -- Duy