Re: [PATCH v3 6/6] diff: shortcut for diff'ing two binary SHA-1 objects

On Fri, Aug 15, 2014 at 12:00 AM, Junio C Hamano [off-list ref] wrote:

Nguyễn Thái Ngọc Duy  [off-list ref] writes:

quoted

diff --git a/t/t1050-large.sh b/t/t1050-large.sh
index 711f22c..b294963 100755
--- a/t/t1050-large.sh
+++ b/t/t1050-large.sh

@@ -116,6 +116,14 @@ test_expect_success 'diff --stat' '
      git diff --stat HEAD^ HEAD
 '

+test_expect_success 'diff' '
+     git diff HEAD^ HEAD
+'
+
+test_expect_success 'diff --cached' '
+     git diff --cached HEAD^
+'

What are these checking?  No check for their outcome?

The first test in this file set $GIT_ALLOC_LIMIT and these commands
would not succeed without the patch. But yes I can check the "binary
files differ" too.
-- 
Duy