Re: [PATCH 2/2] fetch: silence git-gc if --quiet is given
From: Jeff King <hidden>
Date: 2016-06-15 23:02:16
On Thu, Aug 14, 2014 at 06:51:05PM +0700, Nguyễn Thái Ngọc Duy wrote:
quoted hunk ↗ jump to hunk
Noticed-by: Matthew Flaschen [off-list ref] Signed-off-by: Nguyễn Thái Ngọc Duy <redacted> --- builtin/fetch.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/builtin/fetch.c b/builtin/fetch.c index 9394194..4ff4080 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c@@ -1197,6 +1197,8 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) string_list_clear(&list, 0); argv_array_pushl(&argv_gc_auto, "gc", "--auto", NULL); + if (verbosity < 0) + argv_array_push(&argv_gc_auto,"--quiet"); run_command_v_opt(argv_gc_auto.argv, RUN_GIT_CMD);
I think this is a fine fix for this specific problem, and we should apply it. But I do wonder if it would be simpler in the long run to treat verbosity as a global option, and pass it around via a GIT_QUIET (or GIT_VERBOSITY) environment variable. I would not be surprised at all to find that there are other cases where sub-programs do not respect the parent verbosity (I know we have had problems with progress reporting flags carried over the transport interface in the past, but I think we fixed all of those). -Peff