Re: [PATCH 1/2] remote.c: don't leak the base branch name in format_tracking_info
From: Stefan Beller <hidden>
Date: 2016-06-15 23:02:14
On 10.08.2014 15:57, Stefan Beller wrote:
quoted hunk ↗ jump to hunk
Found by scan.coverity.com (Id: 1127809) Signed-off-by: Stefan Beller <redacted> --- remote.c | 1 + 1 file changed, 1 insertion(+)diff --git a/remote.c b/remote.c index 3d6c86a..2c1458f 100644 --- a/remote.c +++ b/remote.c@@ -1983,6 +1983,7 @@ int format_tracking_info(struct branch *branch, struct strbuf *sb) strbuf_addf(sb, _(" (use \"git pull\" to merge the remote branch into yours)\n")); } + free(base); return 1; }
Upon testing this one again, I get a warning
remote.c: In function ‘format_tracking_info’:
remote.c:1986:2: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [enabled by default]
free(base);
^
In file included from git-compat-util.h:103:0,
from cache.h:4,
from remote.c:1:
/usr/include/stdlib.h:483:13: note: expected ‘void *’ but argument is of type ‘const char *’
extern void free (void *__ptr) __THROW;
^
Please ignore this patch.