Thread (115 messages) flat view 115 messages, 7 authors, 2016-06-15

Re: [PATCH v2 02/23] rebase -i: allow squashing empty commits without complaints

From: Peter Krefting <hidden>
Date: 2016-06-15 23:02:09

Fabian Ruch:
quoted
  2. Notice ourselves that the end-result of the whole squash is an
     empty commit, and stop to let the user deal with it.
This patch chooses the second alternative. Either way seems OK. The 
crucial consensus of the discussion was to silently throw away empty 
interim commits.
Yes, the important part is that giving good advice is better than 
giving bad advice. Thank you for taking your time to fix this.

I haven't reviewed the changes themselves, but I am happy with the 
underlying idea.

-- 
\\// Peter - http://www.softwolves.pp.se/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help