Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v7 5/8] config: add `git_die_config()` to the config-set API

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:02:08

Matthieu Moy [off-list ref] writes:
Tanay Abhra [off-list ref] writes:
quoted
Currently works like the old git_config() error reporting path. If err is set to "NULL",
it would print no error message and just the die message. If given something like,

	 git_config_die(key, "value '%s' is not allowed", value);

it would print,

	error: value '3' is not allowed
	fatal: bad config variable 'core.frotz' at file line 15 in .git/config
That seems to be a good step forward.

I think we would also want to improve the error message, but that
shouldn't block your series from inclusion: we can do that later without
API change.
Yup, I agree with your assessment.

Thank you, both, for good polishing.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help