Re: [PATCH 2/5] prune --repos: fix uninitialized access
From: Duy Nguyen <hidden>
Date: 2016-06-15 23:02:01
On Thu, Jul 24, 2014 at 2:59 AM, Junio C Hamano [off-list ref] wrote:
It does not explain what the change to the test is about, though.
The old test and code are wrong. We want to verify repos are not pruned if they're new (like, just created). But "git prune" without --expire sets expire time to 0xffffffff (everything will be pruned) so today's repos are pruned as well. But the old code is wrong. It returns 0 at the end of prune_repo_dir instead of1, so st.st_mtime is never checked, the repos are not pruned. The end result is an incorrect passed test :( -- Duy