Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] config.c: change the function signature of `git_config_string()`

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:02:00

Junio C Hamano [off-list ref] writes:
*1* We have safe_create_leading_directories_const() that works
around this for input parameter around its _const less counterpart,
which is ugly but livable solution.
I think it would actually be a reasonable solution to avoid casting here
and there on the caller side.

Another option would be to _return_ a non-const char * instead of
outputing it as a by-address parameter. We'd lose the consiseness of

   return git_config_get_string(...)

(but in cases where the return value is ignored, we do not really care)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help