Thread (13 messages) flat view 13 messages, 4 authors, 2016-06-15

Re: [PATCH v2 1/2] lockfile.c: remove PATH_MAX limitation (except in resolve_symlink)

From: Duy Nguyen <hidden>
Date: 2016-06-15 23:01:59

On Sun, Jul 20, 2014 at 7:47 PM, Philip Oakley [off-list ref] wrote:
From: "Nguyễn Thái Ngọc Duy" <redacted>
quoted
Something extra is, because struct lock_file is usually used as static
variables in many places. This patch reduces bss section by about 80k
bytes (or 23%) on Linux.

This didn't scan for me. Perhaps it's the punctuation. Maybe:

Additionally, because the struct lock_file variables are [were] in many
places static, this patch reduces the bss section size by about 80k

bytes (or 23%) on Linux.

Does my tweak reflect your intent?
Yes. But I should probably put that below the "---" line. We're not
busybox. 80k is pratically nothing.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help