Re: [PATCH 05/12] refs.c: pass NULL as *flags to read_ref_full
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:01:58
Ronnie Sahlberg [off-list ref] writes:
We call read_ref_full with a pointer to flags from rename_ref but since we never actually use the returned flags we can just pass NULL here instead.
Sensible, at least for the current callers. I had to wonder if rename_ref() would never want to take advantage of the flags return parameter in the future, though. For example, would it want to act differently when the given ref turns out to be a symref? Would it want to report something when the ref to be overwritten was a broken one?
quoted hunk
Reviewed-by: Jonathan Nieder <redacted> Signed-off-by: Ronnie Sahlberg <redacted> --- refs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/refs.c b/refs.c index 7d65253..0df6894 100644 --- a/refs.c +++ b/refs.c@@ -2666,7 +2666,7 @@ int rename_ref(const char *oldrefname, const char *newrefname, const char *logms goto rollback; } - if (!read_ref_full(newrefname, sha1, 1, &flag) && + if (!read_ref_full(newrefname, sha1, 1, NULL) && delete_ref(newrefname, sha1, REF_NODEREF)) { if (errno==EISDIR) { if (remove_empty_directories(git_path("%s", newrefname))) {