Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw
From: Erik Faye-Lund <hidden>
Date: 2016-06-15 23:01:58
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw · Junio C Hamano <hidden>
- 2016-06-15 · Re: Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw · Johannes Schindelin <hidden>
- 2016-06-15 · Re: Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw · Johannes Sixt <hidden>
- 2016-06-15 · Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw · Junio C Hamano <hidden>
On Thu, Jul 17, 2014 at 5:37 PM, Stepan Kasal [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Pat Thoyts <redacted> On Windows the application command line is provided as unicode and in mingw-git we convert that to utf-8. So these tests that require a iso-8859-1 input are being subverted by the encoding transformations we perform and should be skipped. Signed-off-by: Pat Thoyts <redacted> Signed-off-by: Stepan Kasal <redacted> --- t/t4210-log-i18n.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/t/t4210-log-i18n.sh b/t/t4210-log-i18n.sh index 52a7472..9110404 100755 --- a/t/t4210-log-i18n.sh +++ b/t/t4210-log-i18n.sh@@ -34,7 +34,7 @@ test_expect_success 'log --grep searches in log output encoding (utf8)' ' test_cmp expect actual ' -test_expect_success 'log --grep searches in log output encoding (latin1)' ' +test_expect_success NOT_MINGW 'log --grep searches in log output encoding (latin1)' ' cat >expect <<-\EOF && latin1 utf8@@ -43,7 +43,7 @@ test_expect_success 'log --grep searches in log output encoding (latin1)' ' test_cmp expect actual ' -test_expect_success 'log --grep does not find non-reencoded values (utf8)' ' +test_expect_success NOT_MINGW 'log --grep does not find non-reencoded values (utf8)' '
Perhaps these checks would be more readable a few years in the future, if we make a separate capability along the lines of NON_UNICODE_LOCALE? -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.