Re: [PATCH v9 1/4] cache-tree: Create/update cache-tree on checkout
From: Torsten Bögershausen <hidden>
Date: 2016-06-15 23:01:56
On 07/13/2014 10:28 PM, David Turner wrote:
From: David Turner <redacted>
[]
quoted hunk ↗ jump to hunk
diff --git a/cache-tree.c b/cache-tree.c index 7fa524a..f951d7d 100644 --- a/cache-tree.c +++ b/cache-tree.c@@ -239,9 +239,12 @@ static int update_one(struct cache_tree *it, struct strbuf buffer; int missing_ok = flags & WRITE_TREE_MISSING_OK; int dryrun = flags & WRITE_TREE_DRY_RUN; + int repair = flags & WRITE_TREE_REPAIR; int to_invalidate = 0; int i; + assert(!(dryrun && repair));
I think something in the spirit of
die("dryrun and repaiir can not be used together"\n)
Would be nicer to the user as well as being more reliable (as assert may
be a no-op in some systems)