[PATCH v21 00/19] Use ref transactions · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 02/19] refs.c: ref_transaction_commit should not free the transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 03/19] refs.c: constify the sha arguments for ref_transaction_create|delete|update · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 01/19] refs.c: remove ref_transaction_rollback · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 07/19] lockfile.c: make lock_file return a meaningful errno on failure · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 09/19] refs.c: make sure log_ref_setup returns a meaningful errno · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 08/19] refs.c: add an err argument to repack_without_refs · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 06/19] lockfile.c: add a new public function unable_to_lock_message · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 12/19] refs.c: commit_packed_refs to return a meaningful errno on failure · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 05/19] refs.c: add a strbuf argument to ref_transaction_commit for error logging · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 04/19] refs.c: allow passing NULL to ref_transaction_free · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 10/19] refs.c: verify_lock should set errno to something meaningful · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 11/19] refs.c: make remove_empty_directories always set errno to something sane · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 16/19] refs.c: make update_ref_write update a strbuf on failure · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 17/19] update-ref: use err argument to get error from ref_transaction_commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 19/19] refs.c: change ref_transaction_update() to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 14/19] refs.c: log_ref_write should try to return meaningful errno · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 13/19] refs.c: make resolve_ref_unsafe set errno to something meaningful on error · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 18/19] refs.c: remove the onerr argument to ref_transaction_commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v21 15/19] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors · Ronnie Sahlberg <hidden> · 2016-06-15

DORMANTno replies REVIEWED: 1 (0M)

Revision v21 of 10 in this series; 1 review trailer.

Revisions (10)

2016-06-15 v11 [diff vs current]
2016-06-15 v13 [diff vs current]
2016-06-15 v14 [diff vs current]
2016-06-15 v15 [diff vs current]
2016-06-15 v16 [diff vs current]
2016-06-15 v17 [diff vs current]
2016-06-15 v18 [diff vs current]
2016-06-15 v19 [diff vs current]
2016-06-15 v20 [diff vs current]
2016-06-15 v21 current

[PATCH v21 11/19] refs.c: make remove_empty_directories always set errno to something sane

From: Ronnie Sahlberg <hidden>
Date: 2016-06-15 23:01:55
Subsystem: the rest · Maintainer: Linus Torvalds

Making errno when returning from remove_empty_directories() more
obviously meaningful, which should provide some peace of mind for
people auditing lock_ref_sha1_basic.

Signed-off-by: Ronnie Sahlberg <redacted>
Reviewed-by: Michael Haggerty <redacted>
---
 refs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/refs.c b/refs.c
index a48f805..cc69581 100644
--- a/refs.c
+++ b/refs.c

@@ -1960,14 +1960,16 @@ static int remove_empty_directories(const char *file)
 	 * only empty directories), remove them.
 	 */
 	struct strbuf path;
-	int result;
+	int result, save_errno;
 
 	strbuf_init(&path, 20);
 	strbuf_addstr(&path, file);
 
 	result = remove_dir_recursively(&path, REMOVE_DIR_EMPTY_ONLY);
+	save_errno = errno;
 
 	strbuf_release(&path);
+	errno = save_errno;
 
 	return result;
 }

@@ -2056,6 +2058,7 @@ int dwim_log(const char *str, int len, unsigned char *sha1, char **log)
 	return logs_found;
 }
 
+/* This function should make sure errno is meaningful on error */
 static struct ref_lock *lock_ref_sha1_basic(const char *refname,
 					    const unsigned char *old_sha1,
 					    int flags, int *type_p)

-- 
2.0.1.546.gf603308