Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2] tag: support configuring --sort via .gitconfig

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:01:52

"Keller, Jacob E" [off-list ref] writes:
On Thu, 2014-07-10 at 15:34 -0400, Jeff King wrote:
quoted
On Thu, Jul 10, 2014 at 10:59:36AM -0700, Junio C Hamano wrote:
quoted
Jeff King [off-list ref] writes:
quoted
I know this is existing code you are moving, but I noticed it looks ripe
for using skip_prefix. Perhaps while we are in the area we should do the
following on top of your patch (I'd also be happy for it be squashed
in, but that may be too much in one patch).
I am tempted to suggest going the other way around, i.e. queue (an
equivalent of) this on jk/skip-prefix and merge it to 'next' and
then 'master' quickly.

I can go either way, but I tend to prefer building new things on top
of obviously correct clean-up, not the other way around.
Me too. I just didn't want to make more work for Jacob (in having to
rebase on top of mine) or for you (in having to do a non-obvious merge a
few days from now).

-Peff
I'm perfectly fine rebasing. :)
Alright, thanks.

I am still not ready to push out today's integration result, but
when it happens, Peff's "tag: use skip_prefix" should appear at
ce85604, as a direct follow-up to the tip of already merged
jk/skip-prefix topic which was 67a31f61 (http-push: refactor parsing
of remote object names, 2014-06-19).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help