Re: [PATCH v6 28/32] gc: style change -- no SP before closing bracket

From
Eric Sunshine <hidden>
Date
2016-06-15 23:01:51
Reply to
Nguyễn Thái Ngọc Duy, 2016-06-15
On Wed, Jul 9, 2014 at 3:33 AM, Nguyễn Thái Ngọc Duy [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
 builtin/gc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/gc.c b/builtin/gc.c
index 8d219d8..53f1302 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -285,7 +285,7 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
                OPT__QUIET(&quiet, N_("suppress progress reporting")),
                { OPTION_STRING, 0, "prune", &prune_expire, N_("date"),
                        N_("prune unreferenced objects"),
-                       PARSE_OPT_OPTARG, NULL, (intptr_t)prune_expire },
+                       PARSE_OPT_OPTARG, NULL, (intptr_t)prune_expire},
Yet, there is a space after the opening '{'. So, this is now
inconsistently formatted as:

    { foo, bar}
quoted hunk ↗ jump to hunk
                OPT_BOOL(0, "aggressive", &aggressive, N_("be more thorough (increased runtime)")),
                OPT_BOOL(0, "auto", &auto_gc, N_("enable auto-gc mode")),
                OPT_BOOL(0, "force", &force, N_("force running gc even if there may be another gc running")),
@@ -298,7 +298,7 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
        argv_array_pushl(&pack_refs_cmd, "pack-refs", "--all", "--prune", NULL);
        argv_array_pushl(&reflog, "reflog", "expire", "--all", NULL);
        argv_array_pushl(&repack, "repack", "-d", "-l", NULL);
-       argv_array_pushl(&prune, "prune", "--expire", NULL );
+       argv_array_pushl(&prune, "prune", "--expire", NULL);
        argv_array_pushl(&rerere, "rerere", "gc", NULL);

        git_config(gc_config, NULL);
--
1.9.1.346.ga2b5940
Thread (78 messages) 78 messages, 5 authors, last reply 2016-06-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help