Re: [PATCH v5 2/2] test-config: Add tests for the config_set API | git | Ratatoskr

[PATCH v5 0/3] git config cache & special querying api utilizing the cache · Tanay Abhra <hidden> · 2016-06-15
[PATCH v5 1/2] add `config_set` API for caching config-like files · Tanay Abhra <hidden> · 2016-06-15
Re: [PATCH v5 1/2] add `config_set` API for caching config-like files · Ramsay Jones <hidden> · 2016-06-15
[PATCH v5 2/2] test-config: Add tests for the config_set API · Tanay Abhra <hidden> · 2016-06-15
Re: [PATCH v5 2/2] test-config: Add tests for the config_set API · Ramkumar Ramachandra <hidden> · 2016-06-15

Re: [PATCH v5 2/2] test-config: Add tests for the config_set API

From: Ramkumar Ramachandra <hidden>
Date: 2016-06-15 23:01:49

A couple of quick nits.

Tanay Abhra wrote:

+test_expect_success 'clear default config' '
+       rm -f .git/config
+'

Unnecessary; a fresh temporary directory is created for each test run.

+test_expect_success 'initialize default config' '

You might want to mark this as "setup".