Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: Passing rev-list options in git-filter-branch broken

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:01:45

Felix Eckhofer [off-list ref] writes:
When trying to rewrite svn revisions in commit messages to
corresponding git commit hashes, I came across the following problem
(using git 1.9.1):

  $ git filter-branch --msg-filter svnrev2git.py -- --date-order --all
  fatal: options not supported in --stdin mode
  Could not get the commits

This seems to have been caused by 3361a548db. After reverting this
commit, using --date-order appears to work again.
Hmph, unfortunate.

3361a548 (Allow git-filter-branch to process large repositories with
lots of branches., 2013-09-10) has this change:

 
    -rev_args=$(git rev-parse --revs-only "$@")
    +git rev-parse --revs-only "$@" >../parse

and then later feeds ../parse from the standard input of rev-list.

The --revs-only option, because --date-order *is* a rev-list related
argument, is emitted by the above rev-parse, along with the tip of
refs (which come from --all).  But --stdin mode of rev-list is meant
to receive *only* revisions, not options.  When it gets to the point
to accept the list of tips to start traversing from, it is too late
to give it an option.

Changing the above to something like:

	git rev-parse --revs-only --no-flags "$@" >../parse

would be a better workaround that would not break repositories with
large number of references, but it obviously will lose --date-order
option (why would it be even necessary, though?  I suspect that
forcing the date-order will make the resulting pack a lot worse by
robbing the data stream of locality).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help