[PATCH v18 00/48] Use ref transactions · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 04/48] refs.c: allow passing NULL to ref_transaction_free · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 01/48] refs.c: remove ref_transaction_rollback · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 02/48] refs.c: ref_transaction_commit should not free the transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 25/48] tag.c: use ref transactions when doing updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 23/48] refs.c: make ref_transaction_begin take an err argument · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 10/48] refs.c: verify_lock should set errno to something meaningful · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v18 10/48] refs.c: verify_lock should set errno to something meaningful · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v18 10/48] refs.c: verify_lock should set errno to something meaningful · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 07/48] lockfile.c: make lock_file return a meaningful errno on failurei · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v18 07/48] lockfile.c: make lock_file return a meaningful errno on failurei · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v18 07/48] lockfile.c: make lock_file return a meaningful errno on failurei · Michael Haggerty <hidden> · 2016-06-15
[PATCH v18 45/48] refs.c: pass a skip list to name_conflict_fn · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 33/48] fast-import.c: use a ref transaction when dumping tags · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 44/48] refs.c: call lock_ref_sha1_basic directly from commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 48/48] refs.c: make write_ref_sha1 static · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 42/48] refs.c: pass NULL as *flags to read_ref_full · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 46/48] refs.c: propagate any errno==ENOTDIR from _commit back to the callers · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 41/48] refs.c: pass the ref log message to _create/delete/update instead of _commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 47/48] fetch.c: change s_update_ref to use a ref transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 37/48] refs.c: remove the update_ref_write function · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 26/48] replace.c: use the ref transaction functions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 30/48] branch.c: use ref transaction for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 34/48] walker.c: use ref transaction for ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 31/48] refs.c: change update_ref to use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 40/48] refs.c: make delete_ref use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 39/48] refs.c: make prune_ref use a transaction to delete the ref · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 35/48] refs.c: make lock_ref_sha1 static · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 27/48] commit.c: use ref transactions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 22/48] refs.c: update ref_transaction_delete to check for error and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 32/48] receive-pack.c: use a reference transaction for updating the refs · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 24/48] refs.c: add transaction.status and track OPEN/CLOSED/ERROR · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 36/48] refs.c: remove the update_ref_lock function · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 29/48] fast-import.c: change update_branch to use ref transactions · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 38/48] refs.c: remove lock_ref_sha1 · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 20/48] refs.c: change ref_transaction_update() to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 14/48] refs.c: log_ref_write should try to return meaningful errno · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v18 14/48] refs.c: log_ref_write should try to return meaningful errno · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v18 14/48] refs.c: log_ref_write should try to return meaningful errno · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 11/48] refs.c: make remove_empty_directories alwasy set errno to something sane · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v18 11/48] refs.c: make remove_empty_directories alwasy set errno to something sane · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v18 11/48] refs.c: make remove_empty_directories alwasy set errno to something sane · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 06/48] lockfile.c: add a new public function unable_to_lock_message · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 15/48] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 19/48] refs.c: remove the onerr argument to ref_transaction_commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 17/48] refs.c: make update_ref_write update a strbuf on failure · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 16/48] refs.c: add an err argument to delete_ref_loose · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v18 16/48] refs.c: add an err argument to delete_ref_loose · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v18 16/48] refs.c: add an err argument to delete_ref_loose · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v18 16/48] refs.c: add an err argument to delete_ref_loose · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v18 16/48] refs.c: add an err argument to delete_ref_loose · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 28/48] sequencer.c: use ref transactions for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 12/48] refs.c: commit_packed_refs to return a meaningful errno on failure · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 18/48] update-ref: use err argument to get error from ref_transaction_commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 09/48] refs.c: make sure log_ref_setup returns a meaningful errno · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 05/48] refs.c: add a strbuf argument to ref_transaction_commit for error logging · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 03/48] refs.c: constify the sha arguments for ref_transaction_create|delete|update · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 13/48] refs.c: make resolve_ref_unsafe set errno to something meaningful on error · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 08/48] refs.c: add an err argument to repack_without_refs · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v18 21/48] refs.c: change ref_transaction_create to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15

Re: [PATCH v18 16/48] refs.c: add an err argument to delete_ref_loose

From: Michael Haggerty <hidden>
Date: 2016-06-15 23:01:41

On 06/19/2014 12:27 AM, Ronnie Sahlberg wrote:

It looks like we need to reorder two of the patches.
This patch needs to be moved to later in the series and happen after
the delete_ref conversion :

refs.c: make delete_ref use a transaction
refs.c: add an err argument to delete_ref_loose

That agrees with what I have found out since my first email.  The
failures go away starting with the later commit that you mentioned.

I will respin a v19 with these patches reordered.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help