Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names
flat view
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:01:36
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names · Heiko Voigt <hidden>
- 2016-06-15 · Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names · Eric Sunshine <hidden>
- 2016-06-15 · Re: Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names · Heiko Voigt <hidden>
- 2016-06-15 · [PATCH 2/5] implement submodule config cache for lookup of submodule names · Heiko Voigt <hidden>
- 2016-06-15 · Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names · W. Trevor King <hidden>
Heiko Voigt [off-list ref] writes:
... +static int is_cache_init = 0;
Please don't initialise variables in the .bss to zero by hand.
quoted hunk
+ ... + warning("%s:.gitmodules, multiple configurations found for " + "submodule.%s.%s. Skipping second one!", + commit_string, name, option); +} + ... + if (strcmp(value, "untracked") && strcmp(value, "dirty") && + strcmp(value, "all") && strcmp(value, "none")) { + warning("Invalid parameter \"%s\" for config option " + "\"submodule.%s.ignore\"", value, var); + goto release_return; + }
These two look inconsistent in different ways. I think we typically
quote the names like so:
warning("I have trouble with variable '%s' somehow", var);