Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] git-submodule.sh: avoid "test <cond> -a/-o <cond>"

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:01:33

Elia Pinto [off-list ref] writes:
quoted hunk
@@ -832,7 +832,7 @@ Maybe you want to use 'update --init'?")"
 			continue
 		fi
 
-		if ! test -d "$sm_path"/.git -o -f "$sm_path"/.git
+		if ! test -d "$sm_path"/.git || test -f "$sm_path"/.git
Which part of test conditions does that "!" apply in the original,
and in the updated? 

I think the new test after || also needs negation, no?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help