Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] git-submodule.sh: avoid "test <cond> -a/-o <cond>"

From: Torsten Bögershausen <hidden>
Date: 2016-06-15 23:01:33

On 2014-06-10 14.28, Elia Pinto wrote:
[]
quoted hunk ↗ jump to hunk
 		# before the first commit: compare with an empty tree
 		head=$(git hash-object -w -t tree --stdin </dev/null)
@@ -1056,13 +1056,17 @@ cmd_summary() {
 		while read mod_src mod_dst sha1_src sha1_dst status sm_path
 		do
 			# Always show modules deleted or type-changed (blob<->module)
-			test $status = D -o $status = T && echo "$sm_path" && continue
+			case "$status" in
+			([DT])
Does this look strange? ^
Should it be
case "$status" in
D|T)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help