Thread (8 messages) 8 messages, 3 authors, 2016-06-15

Re: [PATCH v5] Add an explicit GIT_DIR to the list of excludes

From: Pasha Bolokhov <hidden>
Date: 2016-06-15 23:01:33

On Thu, Jun 5, 2014 at 3:15 AM, Pasha Bolokhov [off-list ref] wrote:
quoted
+       /* only add it if GIT_DIR does not end with '.git' or '/.git' */
+       if (len < 4 || strcmp(n_git + len - 4, ".git") ||
+           (len > 4 && n_git[len - 5] != '/')) {
Hmm.. should we exclude "foobar.git" as well?
    Why wouldn't we? Everything that has basename ".git" is hard-wired
to be excluded, but everything else, including "foobar.git" should be
added to the excludes manually... How is it better than just "foobar"?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help