Thread (13 messages) flat view 13 messages, 4 authors, 2016-06-15
STALE3732d

Revision v1 of 5 in this series.

Revisions (5)
  1. v1 current
  2. v2 [diff vs current]
  3. v3 [diff vs current]
  4. v4 [diff vs current]
  5. v5 [diff vs current]

[PATCH 0/5] submodule config lookup API

From: Heiko Voigt <hidden>
Date: 2016-06-15 23:01:29

I have been holding back this series during the RC phase but now I think
it is ready for another round. The most important changes:

  * The API is using a singleton now. No need to pass in the cache
    object anymore.

  * Local configuration can be looked up by passing in the null_sha1

  * We use the API for existing lookup of submodule values

One open question:

  * Since behind the scenes there is a global cache filled with the
    values: Do we need to free it explicitely? Or is it ok to let it be
    dealt with on exit?

The last iteration was here:

http://article.gmane.org/gmane.comp.version-control.git/243818

Heiko Voigt (5):
  hashmap: add enum for hashmap free_entries option
  implement submodule config cache for lookup of submodule names
  extract functions for submodule config set and lookup
  use new config API for worktree configurations of submodules
  do not die on error of parsing fetchrecursesubmodules option

 .gitignore                                       |   1 +
 Documentation/technical/api-hashmap.txt          |   2 +-
 Documentation/technical/api-submodule-config.txt |  63 ++++
 Makefile                                         |   2 +
 builtin/checkout.c                               |   1 +
 builtin/fetch.c                                  |   1 +
 diff.c                                           |   1 +
 diffcore-rename.c                                |   2 +-
 hashmap.c                                        |   2 +-
 hashmap.h                                        |   8 +-
 name-hash.c                                      |   4 +-
 submodule-config.c                               | 435 +++++++++++++++++++++++
 submodule-config.h                               |  29 ++
 submodule.c                                      | 122 ++-----
 submodule.h                                      |   4 +-
 t/t7410-submodule-config.sh                      | 141 ++++++++
 test-hashmap.c                                   |   6 +-
 test-submodule-config.c                          |  74 ++++
 18 files changed, 791 insertions(+), 107 deletions(-)
 create mode 100644 Documentation/technical/api-submodule-config.txt
 create mode 100644 submodule-config.c
 create mode 100644 submodule-config.h
 create mode 100755 t/t7410-submodule-config.sh
 create mode 100644 test-submodule-config.c

-- 
2.0.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help