[PATCH v3 2/9] connect.c: replace signal() with sigaction()
From: Jeremiah Mahler <hidden>
Date: 2016-06-15 23:01:26
Subsystem:
the rest · Maintainer:
Linus Torvalds
From the signal(2) man page: The behavior of signal() varies across UNIX versions, and has also var‐ ied historically across different versions of Linux. Avoid its use: use sigaction(2) instead. Replaced signal() with sigaction() in connect.c Signed-off-by: Jeremiah Mahler <redacted> --- connect.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/connect.c b/connect.c
index a983d06..1dc51b2 100644
--- a/connect.c
+++ b/connect.c@@ -665,11 +665,14 @@ struct child_process *git_connect(int fd[2], const char *url, enum protocol protocol; const char **arg; struct strbuf cmd = STRBUF_INIT; + struct sigaction sa; /* Without this we cannot rely on waitpid() to tell * what happened to our children. */ - signal(SIGCHLD, SIG_DFL); + memset(&sa, 0, sizeof(sa)); + sa.sa_handler = SIG_DFL; + sigaction(SIGCHLD, &sa, NULL); protocol = parse_connect_url(url, &hostandport, &path); if (flags & CONNECT_DIAG_URL) {
--
2.0.0.8.g7bf6e1f.dirty