Thread (89 messages) flat view 89 messages, 2 authors, 2016-06-15

Re: [PATCH v11 36/41] refs.c: move the check for valid refname to lock_ref_sha1_basic

From: Jonathan Nieder <hidden>
Date: 2016-06-15 23:01:26

Ronnie Sahlberg wrote:
Move the check for check_refname_format from lock_any_ref_for_update
to lock_ref_sha1_basic. At some later stage we will get rid of
lock_any_ref_for_update completely.
Do you know if this will cause any functional change?

What is the potential impact?  Is that impact worth it?  (Given how
broken the recovery codepaths currently are, I suspect this change is
worth it, but it seems worth documenting in the log message.)

Thanks,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help