Re: [PATCH v1 1/3] replace: add --graft option

On Fri, May 23, 2014 at 5:22 PM, Junio C Hamano [off-list ref] wrote:

Jeff King [off-list ref] writes:

quoted

On Fri, May 23, 2014 at 01:05:40PM -0700, Junio C Hamano wrote:

quoted

I just read read_graft_line(); it allows an empty line (both
length-0 before the terminating LF or CRLF, and a line with
isspace() only) and ignore them, so "grep '^[^#]'" is not
sufficient.

Thanks, I missed the space trimming. I think:

  grep '^[^# \t]'

would be enough, though I am not sure that "\t" is portable over a raw
tab.

'grep' does not recognize "\t" on BSD or derivatives, such as Mac OS
X. (Nor does 'sed'.)