Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 10/19] git-submodule.sh: convert test -a/-o to && and ||

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:01:15

Elia Pinto [off-list ref] writes:
-			test $status = D -o $status = T && echo "$sm_path" && continue
+			{
+			test "$status" = D ||
+			test "$status" = T
+			} &&
+			echo "$sm_path"
+			&& continue
We usually write the && at the end of the line, hence that would be

echo "$sm_path" &&
continue

(shouldn't block the patch, but you may change if you need to resend)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help