Thread (22 messages) flat view 22 messages, 3 authors, 2016-06-15
STALE3727d

[PATCH 01/19] check_bindir: convert test -a/-o to && and ||

From: Elia Pinto <hidden>
Date: 2016-06-15 23:01:15
Subsystem: the rest · Maintainer: Linus Torvalds

The interaction with unary operators and operator precedence
for && and || are better known than -a and -o, and for that
reason we prefer them. Replace all existing instances
of -a and -o to save readers from the burden of thinking
about such things.

Signed-off-by: Elia Pinto <redacted>
---
 check_bindir |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/check_bindir b/check_bindir
index a1c4c3e..623eadc 100755
--- a/check_bindir
+++ b/check_bindir
@@ -2,7 +2,7 @@
 bindir="$1"
 gitexecdir="$2"
 gitcmd="$3"
-if test "$bindir" != "$gitexecdir" -a -x "$gitcmd"
+if test "$bindir" != "$gitexecdir" && test -x "$gitcmd"
 then
 	echo
 	echo "!! You have installed git-* commands to new gitexecdir."
-- 
1.7.10.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help