Thread (4 messages) 4 messages, 3 authors, 2016-06-15

Re: [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:01:08

Jonathan Nieder [off-list ref] writes:
quoted
quoted
+		if (opt.ignore_case && !strcmp("less", pager))
+			string_list_append(&path_list, "-i");
I have a feeling that this goes against the recent trend of not
mucking with the expectation of the users on their pagers, if I
recall correctly the arguments for dropping S from the default given
to an unconfigured LESS environment variable.
It's just missing an explanation.
...
(That's -I, not -i, because it ought to work even when the pattern
contains capital letters.)
Spot on.  The change, especially with "-I", makes sense.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help