[PATCH v6 00/42] Use ref transactions for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 01/42] refs.c: constify the sha arguments for ref_transaction_create|delete|update · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 02/42] refs.c: allow passing NULL to ref_transaction_free · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 02/42] refs.c: allow passing NULL to ref_transaction_free · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v6 02/42] refs.c: allow passing NULL to ref_transaction_free · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 02/42] refs.c: allow passing NULL to ref_transaction_free · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 19/42] refs.c: ref_transaction_commit should not free the transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 20/42] fetch.c: clear errno before calling functions that might set it · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 20/42] fetch.c: clear errno before calling functions that might set it · Eric Sunshine <hidden> · 2016-06-15
Re: [PATCH v6 20/42] fetch.c: clear errno before calling functions that might set it · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 40/42] refs.c: pass a skip list to name_conflict_fn · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 40/42] refs.c: pass a skip list to name_conflict_fn · Eric Sunshine <hidden> · 2016-06-15
Re: [PATCH v6 40/42] refs.c: pass a skip list to name_conflict_fn · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 42/42] refs.c: remove forward declaraion of write_ref_sha1 · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 22/42] fetch.c: use a single ref transaction for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 23/42] receive-pack.c: use a reference transaction for updating the refs · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 21/42] fetch.c: change s_update_ref to use a ref transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 41/42] refs.c: make rename_ref use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 39/42] refs.c: add a new flag for transaction delete for refs we know are packed only · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 36/42] refs.c: pack all refs before we start to rename a ref · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 37/42] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 38/42] refs.c: call lock_ref_sha1_basic directly from commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 34/42] refs.c: pass the ref log message to _create/delete/update instead of _commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 32/42] refs.c: make prune_ref use a transaction to delete the ref · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 29/42] refs.c: remove the update_ref_lock function · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 28/42] refs.c: add transaction.status and track OPEN/CLOSED/ERROR · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 26/42] refs.c: make write_ref_sha1 static · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 25/42] walker.c: use ref transaction for ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 30/42] refs.c: remove the update_ref_write function · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 27/42] refs.c: make lock_ref_sha1 static · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 33/42] refs.c: make delete_ref use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 31/42] refs.c: remove lock_ref_sha1 · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 24/42] fast-import.c: use a ref transaction when dumping tags · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 35/42] refs.c: pass NULL as *flags to read_ref_full · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 10/42] refs.c: ref_transaction_delete to check for error and return status · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 10/42] refs.c: ref_transaction_delete to check for error and return status · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v6 10/42] refs.c: ref_transaction_delete to check for error and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 18/42] refs.c: free the transaction before returning when number of updates is 0 · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 16/42] branch.c: use ref transaction for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 17/42] refs.c: change update_ref to use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 13/42] commit.c: use ref transactions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 13/42] commit.c: use ref transactions for updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v6 13/42] commit.c: use ref transactions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 11/42] tag.c: use ref transactions when doing updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 11/42] tag.c: use ref transactions when doing updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v6 11/42] tag.c: use ref transactions when doing updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 11/42] tag.c: use ref transactions when doing updates · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v6 12/42] replace.c: use the ref transaction functions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 12/42] replace.c: use the ref transaction functions for updates · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v6 12/42] replace.c: use the ref transaction functions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 14/42] sequencer.c: use ref transactions for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 14/42] sequencer.c: use ref transactions for all ref updates · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v6 15/42] fast-import.c: change update_branch to use ref transactions · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 08/42] refs.c: change ref_transaction_update() to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 08/42] refs.c: change ref_transaction_update() to do error checking and return status · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v6 08/42] refs.c: change ref_transaction_update() to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 08/42] refs.c: change ref_transaction_update() to do error checking and return status · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v6 08/42] refs.c: change ref_transaction_update() to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 07/42] refs.c: remove the onerr argument to ref_transaction_commit · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 07/42] refs.c: remove the onerr argument to ref_transaction_commit · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v6 09/42] refs.c: change ref_transaction_create to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 09/42] refs.c: change ref_transaction_create to do error checking and return status · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v6 09/42] refs.c: change ref_transaction_create to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 09/42] refs.c: change ref_transaction_create to do error checking and return status · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v6 05/42] update-ref.c: log transaction error from the update_ref · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 05/42] update-ref.c: log transaction error from the update_ref · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v6 05/42] update-ref.c: log transaction error from the update_ref · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 04/42] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 04/42] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v6 04/42] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v6 06/42] refs.c: make update_ref_write update a strbuf on failure · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 06/42] refs.c: make update_ref_write update a strbuf on failure · Jonathan Nieder <hidden> · 2016-06-15
[PATCH v6 03/42] refs.c: add a strbuf argument to ref_transaction_commit for error logging · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 03/42] refs.c: add a strbuf argument to ref_transaction_commit for error logging · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v6 03/42] refs.c: add a strbuf argument to ref_transaction_commit for error logging · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 00/42] Use ref transactions for all ref updates · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v6 00/42] Use ref transactions for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v6 00/42] Use ref transactions for all ref updates · Jonathan Nieder <hidden> · 2016-06-15

Re: [PATCH v6 04/42] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors

From: Jonathan Nieder <hidden>
Date: 2016-06-15 23:01:08

Ronnie Sahlberg wrote:

Make ref_update_reject_duplicates return any error that occurs through a
new strbuf argument.

Sensible.  The caller-visible effect would be that now
ref_transaction_commit() can pass back a helpful error message through
its "err" argument when asked to make multiple updates for the same
ref.

Reviewed-by: Jonathan Nieder <redacted>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help