Re: [PATCH 9/9] diff: convert struct combine_diff_path to object_id
From: Michael Haggerty <hidden>
Date: 2016-06-15 23:01:01
On 05/03/2014 10:12 PM, brian m. carlson wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: brian m. carlson <redacted> --- combine-diff.c | 54 +++++++++++++++++++++++++++--------------------------- diff-lib.c | 10 +++++----- diff.h | 5 +++-- 3 files changed, 35 insertions(+), 34 deletions(-)diff --git a/combine-diff.c b/combine-diff.c index 24ca7e2..f97eb3a 100644 --- a/combine-diff.c +++ b/combine-diff.c[...]
This file also has two literal "40" constants in it that are probably GIT_OID_HEXSZ. FWIW, I glanced over all of the patches in this series (though without systematically looking for other literal constants that should be derived from GIT_OID_RAWSZ and GIT_OID_HEXSZ) and, aside from the problems that I already noted, they looked OK to me. Michael -- Michael Haggerty mhagger@alum.mit.edu http://softwareswirl.blogspot.com/