Thread (8 messages) flat view 8 messages, 3 authors, 2016-06-15

Re: [RFD] use approxidate for "git commit --date=xyz"?

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:00:57

Possibly related (same subject, not in this thread)

Linus Torvalds [off-list ref] writes:
I just got a comment saying that

    git commit --amend --date=now

doesn't work. I replied that you can use

   --date="$(date)"
Offhand without double-checking the actual codepath I do not have
objection against approxidate-careful.

But why does the workflow need --date=now in the first place?
Wouldn't --reset-author do what you want better?  What is the
situation where you want to say that this patch has been changed
significantly enough from the original to label it with the current
timestamp without taking the authorship?
but I do wonder if we should accept the approxidate format - we do in
other equivalent places. Hmm?

The code uses fmt_ident(), which uses parse_date(), which in turn uses
parse_date_basic(). Maybe parse_date() could use
"approxidate_careful()" instead of "parse_date_basic()"?

            Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help