RE: [PATCH] zsh completion: 5.0.3 compat, use emulate

Felipe Contreras wrote:

Phil Pennock wrote:

quoted

The bash completion pulled into zsh was being pulled in _as_ zsh, but
used patterns which relied on falling through as unhandled.  In zsh
5.0.3 this no longer works, resulting in:

    __git_complete_remote_or_refspec:33: bad pattern: +*

Fix by telling zsh to emulate sh while sourcing the bash config file,
which stickily preserves compatibility options in the function context.
This usage of "emulate" came in with zsh 4.3.10, released 2009-06-01.

I'm using 5.9.5 and I don't see any issue. Howe exactly have you
configured this script?

I meant 5.0.5.

Anyway, I've tried with multiple versions of zsh and I'm able to
reproduce the issue by doing 'git push origin <tab>'. However, it seems
the issue was instroduced in 5.0.3, and fixed in 5.0.4, so I don't think
we should do anything on our side.

-- 
Felipe Contreras