Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:00:53

Junio C Hamano [off-list ref] writes:
"brian m. carlson" [off-list ref] writes:
quoted
quoted
 CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
 	-e 's/^Signed-off-by: \(.*\)/\1,/gp'`
It looks like you may have missed a usage here due to the line break.
Good eyes ;-)

The following may be an obvious replacement patch, but alternatively
we could just drop the whole thing (contrib/ material is not
something we would need to police strictly for the style---nobody
should be mimicking their styles as they are not part of _our_
codebase in the first place).
My vote goes for keeping the patch as it is, so that future people
grepping for `...` construct do not find any after the series is
finished.

(and because it's simple to do)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help