Re: [PATCH] git-rebase: fix probable reflog typo

Felipe Contreras [off-list ref] writes:

Matthieu Moy wrote:

quoted

Felipe Contreras [off-list ref] writes:

quoted

Commit 26cd160 (rebase -i: use a better reflog message) tried to produce
a better reflog message, however, it seems a statement was introduced by
mistake.

'comment_for_reflog start' basically overides the GIT_REFLOG_ACTION we
just set.

quoted

So, one needs to reset $GIT_REFLOG_ACTION to what it used to be if is it
to be used later. However, it seems to me that the "comment_for_reflog
start" is used only for this checkout command. If so, there's no need
for the "comment_for_reflog start" before the if statement either.

Exactly. But if this variable is only meant for this command, it should be
`VAR=VAL command`, that would make it clear without the need of a comment.

I don't understand. Are you suggesting to replace the shell function
"output" with an external command? If not, which command would you want
to call here?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

Matthieu Moy wrote:

Felipe Contreras [off-list ref] writes:

quoted

Matthieu Moy wrote:

quoted

Felipe Contreras [off-list ref] writes:

quoted

Commit 26cd160 (rebase -i: use a better reflog message) tried to produce
a better reflog message, however, it seems a statement was introduced by
mistake.

'comment_for_reflog start' basically overides the GIT_REFLOG_ACTION we
just set.

quoted

So, one needs to reset $GIT_REFLOG_ACTION to what it used to be if is it
to be used later. However, it seems to me that the "comment_for_reflog
start" is used only for this checkout command. If so, there's no need
for the "comment_for_reflog start" before the if statement either.

Exactly. But if this variable is only meant for this command, it should be
`VAR=VAL command`, that would make it clear without the need of a comment.

I don't understand. Are you suggesting to replace the shell function
"output" with an external command? If not, which command would you want
to call here?

Recently some code was changed to do 'test_must_fail env VAR=VAL command', why
can't we do the same?

-- 
Felipe Contreras