Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 17/19] Portable alloca for Git

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:00:40

Erik Faye-Lund [off-list ref] writes:
quoted
Subject: [PATCH] mingw: activate alloca

Both MSVC and MINGW have alloca(3) definitions in malloc.h, so by moving
win32-compat alloca.h from compat/vcbuild/include/ to compat/win32/ ,
which is included by both MSVC and MINGW CFLAGS, we can make alloca()
work on both those Windows environments.

In MINGW, malloc.h has explicit check for GNUC and if it is so, defines
alloca to __builtin_alloca, so it looks like we don't need to add any
code to here-shipped alloca.h to get optimum performance.

Compile-tested on Windows in MSysGit.

Signed-off-by: Kirill Smelkov <redacted>
Looks good to me!
Thanks; queued and pushed out on 'next'.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help