Re: [PATCH 1/2] status: allow NULL fmt for status_printf/status_vprintf_ln
From: Eric Sunshine <hidden>
Date: 2016-06-15 23:00:16
On Mon, Mar 10, 2014 at 3:27 PM, Benoit Pierre [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Useful for calling status_printf only to change/reset the color (and output an additional '\n' with status_vprintf_ln). Signed-off-by: Benoit Pierre <redacted> --- wt-status.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/wt-status.c b/wt-status.c index 4e55810..17f63a4 100644 --- a/wt-status.c +++ b/wt-status.c@@ -49,7 +49,8 @@ static void status_vprintf(struct wt_status *s, int at_bol, const char *color, struct strbuf linebuf = STRBUF_INIT; const char *line, *eol; - strbuf_vaddf(&sb, fmt, ap); + if (NULL != fmt)
In this codebase,
if (fmt)
would be more idiomatic.
+ strbuf_vaddf(&sb, fmt, ap);
if (!sb.len) {
if (s->display_comment_prefix) {
strbuf_addch(&sb, comment_line_char);
--
1.9.0