Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH v7 00/11] Add interpret-trailers builtin

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:00:14

Christian Couder [off-list ref] writes:
* many style fixes
This round is readable ;-)  Thanks.
* clearer and nicer setup tests
Those long lines that use "printf" with many embedded \n were harder
to read and also looked harder to maintain if we ever wanted to
change them.  Splicing a string with \n in the middle of a long
single line is far harder than adding an independent line, I would
think.  For example:

	... &&
	printf "Fixes: \nAcked-by= \nReviewed-by: \nSigned-off-by: \n" >>expected &&
	...

is easier to read and maintain if written like so (with using HT
properly---our MUAs may damage it and turn the indentation into
spaces):

	... &&
	sed -e "s/ Z$/ /" >>expect <<-\EOF &&
        Fixes: Z
        Acked-by= Z
        Reviewed-by: Z
        Signed-off-by: Z
	EOF
	...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help