Re: [PATCH 0/6] fix hunk editing with 'commit -p -m'

Benoit Pierre [off-list ref] writes:

This patch fixes the fact that hunk editing with 'commit -p -m' does not work:
GIT_EDITOR is set to ':' to indicate to hooks that no editor will be launched,
which result in the 'hunk edit' option not launching the editor (and selecting
the whole hunk).

The fix consists in deferring the GIT_EDITOR override to the hook subprocess,
like it's already done for GIT_INDEX_FILE:
- modify 'run_hook' so the first parameter is the environment to set
- add a 'run_hook_v' variant that take a va_list
- add a new 'run_commit_hook' helper (to set both GIT_EDITOR and GIT_INDEX_FILE)

I sense that this is in line with one of the "leftover bits" items I
keep in http://git-blame.blogspot.com/p/leftover-bits.html,
especially http://thread.gmane.org/gmane.comp.version-control.git/192669/focus=192806
;-)