Thread (21 messages) flat view 21 messages, 5 authors, 2016-06-15

Re: [PATCH v6 04/11] trailer: process command line trailer arguments

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:00:12

Christian Couder [off-list ref] writes:
quoted hunk ↗ jump to hunk
diff --git a/trailer.c b/trailer.c
index 5b8e28b..5d69c00 100644
--- a/trailer.c
+++ b/trailer.c
@@ -378,3 +378,96 @@ static int git_trailer_config(const char *conf_key, const char *value, void *cb)
...
+static struct trailer_item *new_trailer_item(struct trailer_item *conf_item,
+					     char* tok, char* val)
Asterisk sticks to the variable, not the type.
+static struct trailer_item *create_trailer_item(const char *string)
+{
...
+	return new_trailer_item(NULL, strbuf_detach(&tok, NULL), strbuf_detach(&val, NULL));;
Overlong line.  Perhaps that helped you to miss the double-semicolon
at the end.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help