Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v3] write_pack_file: use correct variable in diagnostic

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:00:10

Sun He [off-list ref] writes:
quoted hunk
'pack_tmp_name' is the subject of the utime() check, so report it in the
warning, not the uninitialized 'tmpname'

Signed-off-by: Sun He <redacted>
---

 Changing the subject and adding valid information as tutored by 
 Eric Sunshine.
 Thanks to him.

 builtin/pack-objects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..4922ce5 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -823,7 +823,7 @@ static void write_pack_file(void)
 				utb.modtime = --last_mtime;
 				if (utime(pack_tmp_name, &utb) < 0)
 					warning("failed utime() on %s: %s",
-						tmpname, strerror(errno));
+						pack_tmp_name, strerror(errno));
 			}
 
 			/* Enough space for "-<sha-1>.pack"? */
Very nicely done.  Thanks.

And big Thanks to Eric guiding this patch through.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help