Re: [PATCH v3 00/11] Use ALLOC_GROW() instead of inline code
From: Eric Sunshine <hidden>
Date: 2016-06-15 23:00:09
On Mon, Mar 3, 2014 at 2:18 AM, Dmitry S. Dolzhenko [off-list ref] wrote:
Dmitry S. Dolzhenko (11): builtin/pack-objects.c: use ALLOC_GROW() in check_pbase_path() bundle.c: use ALLOC_GROW() in add_to_ref_list() cache-tree.c: use ALLOC_GROW() in find_subtree() commit.c: use ALLOC_GROW() in register_commit_graft() diff.c: use ALLOC_GROW() diffcore-rename.c: use ALLOC_GROW() patch-ids.c: use ALLOC_GROW() in add_commit() replace_object.c: use ALLOC_GROW() in register_replace_object() reflog-walk.c: use ALLOC_GROW() dir.c: use ALLOC_GROW() in create_simplify() attr.c: use ALLOC_GROW() in handle_attr_line() attr.c | 7 +------ builtin/pack-objects.c | 9 +++------ bundle.c | 6 +----- cache-tree.c | 6 +----- commit.c | 8 ++------ diff.c | 12 ++---------- diffcore-rename.c | 12 ++---------- dir.c | 5 +---- patch-ids.c | 5 +---- reflog-walk.c | 12 ++---------- replace_object.c | 8 ++------ 11 files changed, 18 insertions(+), 72 deletions(-) -- 1.8.5.3 This version differs from previous only minor changes: - update commit messages - keep code lines within 80 columns
Place this commentary at the top of the cover letter since that's where people look for it. You want to ease the reviewer's job as much as possible, so it helps to link to the previous submission, like this [1]. Likewise, you can help the reviewer by being more specific about how you updated the commit messages (and perhaps by linking to the relevant discussion points, like this [2][3]). [1]: http://thread.gmane.org/gmane.comp.version-control.git/242857 [2]: http://article.gmane.org/gmane.comp.version-control.git/243004 [3]: http://article.gmane.org/gmane.comp.version-control.git/243049