Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH v3 01/25] path.c: make get_pathname() return strbuf instead of static buffer

From: Duy Nguyen <hidden>
Date: 2016-06-15 23:00:07

On Thu, Feb 20, 2014 at 6:26 AM, Junio C Hamano [off-list ref] wrote:
Is there a reason not to do just an equivalent of

    #define git_pathdup mkpathdup

and be done with it?  Am I missing something?
They have a subtle difference: mkpathdup() calls cleanup_path() while
git_pathdup() does not. Without auditing all call sites, we can't be
sure this difference is insignificant. So I keep both functions
separate for now.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help