Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Rewrite git-compat-util.h:skip_prefix() as a loop

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:00:03

Sun He [off-list ref] writes:
quoted hunk
Signed-off-by: Sun He <redacted>
---
 git-compat-util.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index cbd86c3..4daa6cf 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -357,8 +357,8 @@ extern int suffixcmp(const char *str, const char *suffix);
 
 static inline const char *skip_prefix(const char *str, const char *prefix)
 {
-	size_t len = strlen(prefix);
-	return strncmp(str, prefix, len) ? NULL : str + len;
+    while( *prefix != '\0' && *str++ == *prefix++ );
+    return *prefix == '\0' ? str : NULL;
Documentation/CodingGuidelines?
 }
 
 #if defined(NO_MMAP) || defined(USE_WIN32_MMAP)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help