Re: [PATCH] sha1_file: fix delta_stack memory leak in unpack_entry

Junio C Hamano [off-list ref] writes:

Jeff King [off-list ref] writes:

quoted

On Fri, Feb 21, 2014 at 06:47:47AM +0700, Nguyễn Thái Ngọc Duy wrote:

quoted

This delta_stack array can grow to any length depending on the actual
delta chain, but we forget to free it. Normally it does not matter
because we use small_delta_stack[] from stack and small_delta_stack
can hold 64-delta chains, more than standard --depth=50 in pack-objects.

Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
 Found when trying to see if making some objects loose at this phase
 could help git-blame and how many objects will be loosened. Gotta go
 soon, didn't really test it, but I bet it'll work.

This looks correct to me.

This comes from abe601bb, right?  The change looks correct to me, too.

Ow, sorry about that.  Thanks for the fix!

-- 
Thomas Rast
tr@thomasrast.ch