Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 1/2] t0003: do not chdir the whole test process

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:59:51

Jonathan Nieder [off-list ref] writes:
Junio C Hamano wrote:
quoted
Moving to some other directory and letting the remainder of the test
pieces to expect that they start there is a bad practice.
I agree with the above, and I like the patch...
quoted
                                                           The test
that contains chdir itself may fail (or by mistake skipped via the
GIT_SKIP_TESTS mechanism) in which case the remainder may operate on
files in unexpected places.
... but this logic seems wrong.  I don't think we've ever supported
setup tests failing or being skipped in the past.
The first set-up test, yes, but something in the middle added as an
afterthought?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help