Re: [PATCH] blame.c: prepare_lines should not call xrealloc for every line

David Kastrup [off-list ref] writes:

Junio C Hamano [off-list ref] writes:

quoted

David Kastrup [off-list ref] writes:

quoted

Anybody know offhand what I should be including here?  It looks like Git
has some fallback definitions of its own, so it's probably not just
<string.h> I should include?

In general, no *.c files outside the compatibility layer should
include anything "#include <system-header.h>", as there seem to be
finicky systems that care about order of inclusion and feature macro
definitions, all of which are meant to be handled by including
git-compat-util.h as the very first thing.

Ok, and that one's not yet in blame.c.  Will include, thanks.

No, don't.  Some well-known *.h files of ourse, most notably
cache.h, are known to include compat-util as the first thing, and
that is what *.c files typically include.